Skip to content

Conversation

zedy-wj
Copy link
Contributor

@zedy-wj zedy-wj commented Jun 3, 2021

1.Updating F# doc to the new SDKs - File Storage

2.Updated files

  • i.docs/fsharp/using-fsharp-on-azure/file-storage.md
  • ii.samples/snippets/fsharp/azure/file-storage.fsx

@jongio for notification.

@dotnet-bot dotnet-bot added this to the June 2021 milestone Jun 3, 2021
@zedy-wj zedy-wj changed the title Update F# on Azure Docs Update F# on Azure Docs - File Storage Jun 3, 2021
@zedy-wj zedy-wj marked this pull request as ready for review June 3, 2021 09:28
@zedy-wj zedy-wj requested a review from cartermp as a code owner June 3, 2021 09:28
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor code changes -- the XYZAsync method calls here make me wonder how this executes. Has this script been tested to make sure all the calls happen when expected?

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All requested changes have been addressed.

This LGTM, and I'll :shipit: now.

@BillWagner BillWagner merged commit 8025e4c into dotnet:main Jul 1, 2021
Youssef1313 pushed a commit to Youssef1313/docs that referenced this pull request Jul 5, 2021
* Updating F# doc to the new SDKs.

* Update F# docs with the new SDKs in file-storage

* Sort the namespace

* some code changes

Co-authored-by: Wenjie Yu <v-wenjyu@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants